Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meshtls): initial guide #1906

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Sep 23, 2024

Copy link

netlify bot commented Sep 23, 2024

Deploy Preview for kuma ready!

Name Link
🔨 Latest commit 701df3f
🔍 Latest deploy log https://app.netlify.com/sites/kuma/deploys/66f27783cc5aae00083abcf6
😎 Deploy Preview https://deploy-preview-1906--kuma.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 88 (🔴 down 5 from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 85 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@slonka slonka marked this pull request as ready for review September 23, 2024 10:56
@slonka slonka requested a review from a team as a code owner September 23, 2024 10:56
@slonka slonka requested review from jijiechen, lukidzi and lahabana and removed request for a team September 23, 2024 10:56
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This guide looks good.

I think a few things:

  1. It would be good to have a mermaid diagram to show what things look like at each step
  2. It would be good at the end to have a section: "Things to remember when migrating to strict TLS" with things like: "before turning something to strict check that this stat is no longer incrementing"

@slonka
Copy link
Contributor Author

slonka commented Sep 24, 2024

It would be good to have a mermaid diagram to show what things look like at each step

added, do you think I should also somehow show when things are in strict vs permissive mode?

It would be good at the end to have a section: "Things to remember when migrating to strict TLS" with things like: "before turning something to strict check that this stat is no longer incrementing"

added that but need to check that metric... @johncowen - did we write down the metrics we want to use in the GUI to show TLS-ed / non TLS-ed requests / connections?

also do you have any other final points that we should add?

@johncowen
Copy link
Contributor

@slonka I think this is what you are talking about:

kumahq/kuma-gui#2974

Lemme know if not!

@slonka
Copy link
Contributor Author

slonka commented Sep 24, 2024

@lahabana - probably shouldn't ask the users to calculate things by hand... maybe we should keep tls_inspector stats for now with a * that it's not 100% sure and point people to GUI once the feature linked by JC makes sense, WDYT?

@lahabana
Copy link
Contributor

Providing at least clarity as to which metrics users should like like seems ok to me no? What's being calculated here?

The graphs look good but would it be helpful to color the arrows depending on TLS and non-TLS traffic?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MeshTLS guide
3 participants