-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(meshtls): initial guide #1906
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: slonka <[email protected]>
✅ Deploy Preview for kuma ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: slonka <[email protected]>
Signed-off-by: slonka <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This guide looks good.
I think a few things:
- It would be good to have a mermaid diagram to show what things look like at each step
- It would be good at the end to have a section: "Things to remember when migrating to strict TLS" with things like: "before turning something to strict check that this stat is no longer incrementing"
Co-authored-by: Charly Molter <[email protected]> Signed-off-by: Krzysztof Słonka <[email protected]>
Signed-off-by: slonka <[email protected]>
Signed-off-by: slonka <[email protected]>
Signed-off-by: slonka <[email protected]>
added, do you think I should also somehow show when things are in
added that but need to check that metric... @johncowen - did we write down the metrics we want to use in the GUI to show TLS-ed / non TLS-ed requests / connections? also do you have any other final points that we should add? |
@slonka I think this is what you are talking about: Lemme know if not! |
@lahabana - probably shouldn't ask the users to calculate things by hand... maybe we should keep |
Providing at least clarity as to which metrics users should like like seems ok to me no? What's being calculated here? The graphs look good but would it be helpful to color the arrows depending on TLS and non-TLS traffic? |
closes #1897
rendered: https://deploy-preview-1906--kuma.netlify.app/docs/dev/guides/progressively-rolling-in-strict-mtls/
Did you sign your commit? Instructions yes
Have you read Contributing guidelines? yes