Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(meshservice): modify targetref #1909

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Sep 24, 2024

I'm struggling a bit, maybe @michaelbeaumont can tell me what else needs to be changed and how he envisioned this.

Should I go through every policy and change MeshService to be compatible with the new form (basically adding namespace and modifying the name - or should I always use labels?)? Or should I add deprecation notice and an example showing the new way?

I started changing federation guide but waiting for some feedback first.

closes #1892

Did you sign your commit? Instructions yes

Have you read Contributing guidelines? yes

Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for kuma failed.

Name Link
🔨 Latest commit a9f3ab1
🔍 Latest deploy log https://app.netlify.com/sites/kuma/deploys/66f2aa67ceb93700087f4c12

Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for kuma ready!

Name Link
🔨 Latest commit 8a6a0a3
🔍 Latest deploy log https://app.netlify.com/sites/kuma/deploys/66f2aa7761ba4c0008f5f052
😎 Deploy Preview https://deploy-preview-1909--kuma.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🟢 up 2 from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 85 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update policy and targetRef docs to reflect using real resources instead of kuma.io/service tags
1 participant