Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(federation): export mesh secrets before Mesh objects #11497

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Sep 20, 2024

This prevents the situation where a Mesh is created before its secrets then apply and the control plane race to create them at the same time.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues -- Federation e2e test flake #11420
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@michaelbeaumont michaelbeaumont requested a review from a team as a code owner September 20, 2024 10:51
@michaelbeaumont michaelbeaumont requested review from Automaat and lobkovilya and removed request for a team September 20, 2024 10:51
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) September 20, 2024 11:00
@lahabana
Copy link
Contributor

I don't understand why the order is important. Is it just that we should order global and meshed resource differently in export?

In any case some PR description should be added here

@michaelbeaumont
Copy link
Contributor Author

I don't understand why the order is important. Is it just that we should order global and meshed resource differently in export?

Because if the Mesh comes before its CA secrets, the CP may notice them missing and try to ensure them concurrently with apply creating them

@michaelbeaumont michaelbeaumont merged commit 89a010f into kumahq:master Sep 20, 2024
18 checks passed
@michaelbeaumont michaelbeaumont deleted the fix/export-ordering branch September 20, 2024 13:31
michaelbeaumont added a commit that referenced this pull request Sep 23, 2024
This fixes changes introduced by #11497. Universal checks whether a mesh exists before allowing a secret to be created.

Signed-off-by: Mike Beaumont <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants