fix(runtime): disable type errors in production and fix zombie proces…

…s collection (#2027)
labring · Aug 14, 2024 · be0d141 · be0d141
1 parent 99ce4f1
commit be0d141
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/runtimes/nodejs/Dockerfile b/runtimes/nodejs/Dockerfile
@@ -1,6 +1,6 @@
 FROM node:20.10.0
 
-RUN apt update && apt-get install build-essential libcairo2-dev libpango1.0-dev libjpeg-dev libgif-dev librsvg2-dev git -y
+RUN apt update && apt-get install build-essential libcairo2-dev libpango1.0-dev libjpeg-dev libgif-dev librsvg2-dev git dumb-init -y
 
 # RUN npm install npm -g
 
@@ -27,4 +27,7 @@ RUN chown node:node /app/package.json
 RUN chown node:node /app/package-lock.json
 
 USER node
-CMD [ "sh", "/app/start.sh" ]
+
+ENTRYPOINT ["/usr/bin/dumb-init", "--"]
+
+CMD [ "sh", "/app/start.sh" ]
diff --git a/runtimes/nodejs/src/handler/typings.ts b/runtimes/nodejs/src/handler/typings.ts
@@ -102,7 +102,10 @@ async function getThreePartyPackageTypings(
       data: pkd.declarations,
     })
   } catch (error) {
-    logger.error(requestId, 'failed to get package typings', error)
+    if (!Config.isProd) {
+      logger.error(requestId, 'failed to get package typings', error)
+    }
+
     return res.send({
       code: 1,
       error: error.toString(),