change label location

labring · Sep 2, 2024 · faeaffc · faeaffc
1 parent 3d62549
commit faeaffc
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/controllers/devbox/internal/controller/devbox_controller.go b/controllers/devbox/internal/controller/devbox_controller.go
@@ -72,15 +72,16 @@ func (r *DevboxReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctr
 	logger := log.FromContext(ctx, "devbox", req.NamespacedName)
 	devbox := &devboxv1alpha1.Devbox{}
 
+	if err := r.Get(ctx, req.NamespacedName, devbox); err != nil {
+		return ctrl.Result{}, client.IgnoreNotFound(err)
+	}
+
 	recLabels := label.RecommendedLabels(&label.Recommended{
 		Name:      devbox.Name,
 		ManagedBy: label.DefaultManagedBy,
 		PartOf:    DevBoxPartOf,
 	})
 
-	if err := r.Get(ctx, req.NamespacedName, devbox); err != nil {
-		return ctrl.Result{}, client.IgnoreNotFound(err)
-	}
 	if devbox.ObjectMeta.DeletionTimestamp.IsZero() {
 		if controllerutil.AddFinalizer(devbox, FinalizerName) {
 			if err := r.Update(ctx, devbox); err != nil {