Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add account gift support float ratios #4153

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Conversation

bxy4543
Copy link
Member

@bxy4543 bxy4543 commented Oct 24, 2023

optimize cloud install.sh
add account gift support float ratios;
default price is reduced to 30%.

πŸ€– Generated by Copilot at 20b3967

Summary

πŸŽπŸ’°πŸ–₯️

This pull request implements two main features: decimal gift percentages and new cloud resource pricing. It also improves the cloud installation script by allowing non-interactive node IP input. The changes involve modifying the ratio variable type, the ratios config map values, the UnitPrice values, and the install.sh script. The corresponding tests and documentation are also updated.

We're coding in the cloud, me hearties, yo ho ho
We're changing types and prices, and testing as we go
We're adding checks and prompts, to make the script run smooth
We're heaving on the giveGift function, on the count of three, we move

Walkthrough

  • Support decimal values for gift percentage based on money spent (link, link, link, link)
  • Update unit prices for cloud resources (link)
  • Allow passing node IPs as argument or environment variable for cloud installation (link)

@sealos-ci-robot
Copy link
Member

sealos-ci-robot commented Oct 24, 2023

πŸ€– Generated by lychee action

Summary

Status Count
πŸ” Total 956
βœ… Successful 375
⏳ Timeouts 0
πŸ”€ Redirected 0
πŸ‘» Excluded 580
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@sweep-ai
Copy link

sweep-ai bot commented Oct 24, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests βœ…

πŸ“’ Thoughts on this report? Let us know!.

@zzjin zzjin added this to the v5.0 milestone Oct 24, 2023
add account gift support float ratios;
default price is reduced to 30%.
@bxy4543 bxy4543 merged commit 099f0f8 into labring:main Oct 24, 2023
63 checks passed
@bxy4543 bxy4543 deleted the change_account branch October 24, 2023 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants