Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Automated CherryPick Update for release-v4.4 #4170

Merged
merged 1 commit into from
Oct 26, 2023
Merged

docs: Automated CherryPick Update for release-v4.4 #4170

merged 1 commit into from
Oct 26, 2023

Conversation

sealos-ci-robot
Copy link
Member

@sealos-ci-robot sealos-ci-robot commented Oct 26, 2023 •
edited by ghost
Loading

🤖 Generated by Copilot at 10eeaba

Summary

🐛♻️📦

This pull request fixes a bug related to the apply command status and the run images feature. It changes the updateStatus function in pkg/apply/applydrivers/apply_drivers_default.go to avoid status conflicts, and removes an unused helper function from pkg/types/v1beta1/cluster.go.

updateStatus changed
skips apply command status
when new images run

Walkthrough

  • Skip status update for apply command when running images (link)
  • Remove unused helper function for creating success command condition (link)

Automated changes by create-pull-request GitHub action

@sweep-ai
Copy link

sweep-ai bot commented Oct 26, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

cuisongliu
cuisongliu requested changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@cuisongliu cuisongliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4.3

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@cuisongliu cuisongliu added this to the v4.3 milestone Oct 26, 2023
@cuisongliu cuisongliu merged commit e8fd12c into release-v4.4 Oct 26, 2023
128 checks passed
@cuisongliu cuisongliu deleted the cherry-pick-release-v4.4-4162 branch October 26, 2023 06:38
@sealos-ci-robot
Copy link
Member Author

/cherry-pick release-v4.3

@sealos-ci-robot
Copy link
Member Author

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/labring/sealos/actions/runs/6650418596

sealos-ci-robot added a commit that referenced this pull request Oct 26, 2023
@sealos-ci-robot @cuisongliu
refactor(main): skip success exec (#4162) (#4170)
6e89410 
Co-authored-by: cuisongliu <[email protected]>
cuisongliu added a commit that referenced this pull request Oct 26, 2023
@sealos-ci-robot @cuisongliu
refactor(main): skip success exec (#4162) (#4170) (#4175)
579a016 
Co-authored-by: cuisongliu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuisongliu cuisongliu cuisongliu approved these changes

Assignees
No one assigned
Labels
area/api area/apply sealos run/apply/scale/reset area/lifecycle-management size/S
Projects
None yet
Milestone
v4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@sealos-ci-robot @cuisongliu