Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(kubepanel): improve the overall style #4494

Merged
merged 14 commits into from
Jan 20, 2024
Merged

style(kubepanel): improve the overall style #4494

merged 14 commits into from
Jan 20, 2024

Conversation

mlhiter
Copy link
Member

@mlhiter mlhiter commented Jan 18, 2024

No description provided.

Copy link

cla-assistant bot commented Jan 18, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

sweep-ai bot commented Jan 18, 2024

Sweeping

Resolving merge conflicts: track the progress here.

I'm currently resolving the merge conflicts in this PR. I will stack a new PR once I'm done.

[!CAUTION]

An error has occurred: Cmd('git') failed due to: exit code(1)
cmdline: git commit -m Start of Merge Conflict Resolution
stdout: 'On branch sweep/main-merge-conflict_0
nothing to commit, working tree clean' (tracking ID: 9d5c96cc5c)

@sealos-ci-robot
Copy link
Member

sealos-ci-robot commented Jan 18, 2024

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 1147
✅ Successful 387
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 759
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

Copy link

cla-assistant bot commented Jan 18, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mlhiter mlhiter changed the title style: improve the overall style style(kubepanel): improve the overall style Jan 18, 2024
@@ -1,4 +1,4 @@
import fs from 'fs';
import fs from 'node:fs';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add a separate "node:"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solved

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0948afe) 65.45% compared to head (d11f0b9) 65.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4494   +/-   ##
=======================================
  Coverage   65.45%   65.45%           
=======================================
  Files           8        8           
  Lines         660      660           
=======================================
  Hits          432      432           
  Misses        180      180           
  Partials       48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c121914yu c121914yu merged commit 2057bca into labring:main Jan 20, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants