Verifier tests (#23)

* Update polynomial_arithmetic.rs

Added more documentation for cargo docs.

* docs/PhantomData in `polynomials.rs`

Added documentation and removed the use of `PhatomData` here as it seemed unnecessary.

* Update evaluation_domain.rs

* addressed some verifier test errors

fixed most borrow checker errors

lifetime annotations, verifier test compiles

cleaned up commented code

update unimplemented message

making it work on composer, assuming you squash this

* saying polynomial in funny voice in my head rn

* cargo fix n format

---------

Co-authored-by: Colin Roberts <[email protected]>
Co-authored-by: Claudia Richoux <[email protected]>

barustenberg-benches/benches/a_benchmark.rs

@@ -1,15 +1,15 @@
 use criterion::{criterion_group, criterion_main, Criterion};
 
 pub fn add_benchmark(c: &mut Criterion) {
-    let mut rvg = barustenberg::test_utils::Rvg::deterministic();
-    let int_val_1 = rvg.sample(&(0..100i32));
-    let int_val_2 = rvg.sample(&(0..100i32));
+    // let mut rvg = barustenberg::test_utils::Rvg::deterministic();
+    // let int_val_1 = rvg.sample(&(0..100i32));
+    // let int_val_2 = rvg.sample(&(0..100i32));
 
-    c.bench_function("add", |b| {
-        b.iter(|| {
-            barustenberg::add(int_val_1, int_val_2);
-        })
-    });
+    // c.bench_function("add", |b| {
+    //     b.iter(|| {
+    //         barustenberg::add(int_val_1, int_val_2);
+    //     })
+    // });
 }
 criterion_group!(benches, add_benchmark);
 criterion_main!(benches);

barustenberg/src/plonk/composer/composer_base.rs

@@ -14,6 +14,7 @@ use crate::{
     },
     polynomials::Polynomial,
     srs::reference_string::ReferenceStringFactory,
+    transcript::Manifest,
 };
 
 pub(crate) const DUMMY_TAG: u32 = 0;
@@ -40,6 +41,12 @@ pub(crate) enum ComposerType {
     StandardHonk,
 }
 
+impl ComposerType {
+    pub(crate) fn create_manifest(self, _x: usize) -> Manifest {
+        unimplemented!("ComposerType::create_manifest")
+    }
+}
+
 #[derive(Debug, PartialEq, Eq, Clone, Copy)]
 pub(crate) struct CycleNode {
     pub(crate) gate_index: u32,
@@ -652,7 +659,7 @@ pub(crate) trait ComposerBase {
                 let mut selector_poly = (*selector_poly).borrow_mut();
                 let selector_poly_coefficients = &mut selector_poly.coefficients;
 
-                let mut reference_string = (*proving_key.reference_string).borrow_mut();
+                let reference_string = (*proving_key.reference_string).borrow_mut();
                 let mut pippenger_runtime_state = proving_key.pippenger_runtime_state.clone();
 
                 // Commit to the constraint selector polynomial and insert the commitment in the verification key.

barustenberg/src/plonk/proof_system/utils/permutation.rs

@@ -1,4 +1,3 @@
-use ark_ec::AffineRepr;
 use ark_ff::{FftField, Field};
 
 use crate::{
@@ -19,10 +18,7 @@ pub(crate) struct PermutationSubgroupElement {
     is_tag: bool,
 }
 
-pub(crate) fn compute_permutation_lagrange_base_single<
-    H: BarretenHasher,
-    Fr: Field + FftField,
->(
+pub(crate) fn compute_permutation_lagrange_base_single<H: BarretenHasher, Fr: Field + FftField>(
     output: &mut Polynomial<Fr>,
     permutation: &[u32],
     small_domain: &EvaluationDomain<Fr>,
@@ -87,4 +83,4 @@ pub(crate) fn compute_permutation_lagrange_base_single_helper<
             }
         }
     }
-}
+}

barustenberg/src/plonk/proof_system/verifier/mod.rs

@@ -26,8 +26,8 @@ use super::verification_key::VerificationKey;
 
 use anyhow::{anyhow, Result};
 
-// #[cfg(test)]
-// mod test;
+#[cfg(test)]
+mod test;
 
 #[derive(Debug)]
 pub struct Verifier<H: BarretenHasher, S: Settings<Hasher = H, Field = Fr, Group = G1Affine>> {