Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating polynomial module #18

Closed
wants to merge 3 commits into from
Closed

Conversation

Autoparallel
Copy link
Collaborator

Description

Added a bunch of documentation for the polynomial modules. Also removed an unnecessary PhantomData.

Added more documentation for cargo docs.
Added documentation and removed the use of `PhatomData` here as it seemed unnecessary.
@laudiacay
Copy link
Owner

are you concerned you'll have to do a second pass? this module is incomplete and will eventually have more functions, i think

@Autoparallel
Copy link
Collaborator Author

are you concerned you'll have to do a second pass? this module is incomplete and will eventually have more functions, i think

No I'm okay with it. I can iterate on things here. This was a good learning xp and I feel more confident in how these things fit together.

In general I'm good with multiple passes -- I like iterative development!

@laudiacay
Copy link
Owner

if you rebase i can merge?

@0xJepsen
Copy link
Collaborator

@Autoparallel want to vibe on this over the weekend?

@laudiacay
Copy link
Owner

hey @Autoparallel did this somehow make it in somewhere to main? I'm trying to merge and I'm finding a lot of "the exact same changes x2"...

@laudiacay
Copy link
Owner

lmk if not. i'm going to hold off on finishing the merge for now

@Autoparallel
Copy link
Collaborator Author

@laudiacay @0xJepsen I'm just going to scrap this. Not really important anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants