LMB-732: Switch kandidaatlijst -> fractie relation #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfidlers
reviewed
Sep 19, 2024
There was a problem hiding this comment.
Looks good and it is published on the internal ldes-stream, but I think this should also be on the abb and public stream (not 100% sure about this).
To do this, you need to add the property to the modelProperties of Fractie in the publisher.ts file of ldes-delta-pusher (around line 96).
to the abb and public ldes-stream
JonasVanHoof
deleted the
LMB-732/switch-kandidaatlijst-fractie-relation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Swtich the relation and make sure it comes on the ldes-feed
How to test
Backend resource does not brake + frontend splitting fractie
Links to other PR's