Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lmb 557 | email for not bekrachtigd mandataris #218

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Lmb 557 | email for not bekrachtigd mandataris #218

wants to merge 8 commits into from

Conversation

JonasVanHoof
Copy link
Contributor

@JonasVanHoof JonasVanHoof commented Sep 19, 2024 •
edited
Loading

Description

An email must be send when a mandataris is for 10 or more days on publication status effectief

How to test

Run the send-emails profile

Links to other PR's

@JonasVanHoof JonasVanHoof self-assigned this Sep 19, 2024
@JonasVanHoof JonasVanHoof mentioned this pull request Sep 19, 2024
Draft
JonasVanHoof
JonasVanHoof commented Sep 20, 2024
View reviewed changes
docker-compose.dev.yml Outdated
Comment on lines 108 to 111
SECURE_CONNECTION: "true"
EMAIL_ADDRESS: "[email protected]"
EMAIL_PASSWORD: "myemailpassword"
FROM_NAME: "Testmailer"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these as not needed for test mode

docker-compose.yml
Comment on lines +241 to +243
EMAIL_ADDRESS: "[email protected]"
EMAIL_PASSWORD: "myemailpassword"
FROM_NAME: "Lokaal Mandatenbeheer"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create ticket for Tim fore these values

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of these are set in this project (https://github.com/lblod/app-complaint-form/blob/6ec0880bac51e5b0a2aaa60af784d42de7f06aad/docker-compose.yml#L114) this is done in the pipeline?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked with Achraf: "rechtstreeks op server. Worden gewoon in database opgeslagen. Geen injecties of pipelines of dergelijke"

docker-compose.dev.yml
@@ -92,3 +92,21 @@ services:
restart: "no"
authorization-wrapper:
restart: "no"
deliver-email:
image: local-deliver-email-service:latest
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the PR redpencilio/deliver-email-service#11 is merged and a new version is published the image here needs to be updated

@JonasVanHoof
Copy link
Contributor Author

FAKE email will be shown in the logs of the service as followed. When WELL_KNOWN_SERVICE: "test" is not set it should use the smtp protocol but for that we first need credentials

deliver-email-1  | Email 3: URI = http://data.lblod.info/id/emails/490b0493-1a08-4956-9ff9-d5f89fdeec3d
deliver-email-1  | Email 3: Email moved to sentbox
deliver-email-1  | Email 3: Email message ID updated
deliver-email-1  | Email 3: MessageId updated from  to <[email protected]>
deliver-email-1  | Email 3: Preview URL https://ethereal.email/message/Zu09yKkMYWsP3tzLZu09y5Hz88aDfgVEAAAADjjWufCQhwP6MEMI3kDaFAg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JonasVanHoof JonasVanHoof

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JonasVanHoof