Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent a warning when installing the lib #151

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dunglas
Copy link

@dunglas dunglas commented Mar 11, 2019

Q A
Bug fix? yes
New feature? yes
BC breaks? yes
Related tickets n/a
License MIT

Prevents the following Flex warning when installing the library:

 Adding phpunit/phpunit as a dependency is discouraged in favor of Symfony's PHPUnit Bridge. 
                                                                                             
  * Instead:
    1. Remove it now: composer remove --dev phpunit/phpunit
    2. Use Symfony's bridge: composer require --dev phpunit

@lchrusciel
Copy link
Owner

Thanks a lot Kevin! I want to take a look and do some refactor anyway around this, so I can pick it up

@lchrusciel
Copy link
Owner

I know, it took me a while, but I finally found some time to do something about it. Unfortunately, I wasn't able to force phpunit bridge to see ApiTestCase, because it is using its own composer autoload definition :(

@lchrusciel
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants