Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved route handlers architecture in Coach - planRoutes #11900

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

ShivangRawat30
Copy link
Contributor

Summary

This is the continuation of the refactoring process for the coach page, transitioning from a global route handler to local route handlers for planRoutes. #11219

References

List of all planRoutes:

Route name Handler/component to refactor Refactor done? How to test the page
PageNames.PLAN_PAGE Doesn't need refactoring - Coach -> Plan
GroupsPage.name showGroupsPage yes Coach -> Plan -> groups
GroupMembersPage.name showGroupsPage yes Coach -> Plan -> Groups -> Select any group
GroupEnrollPage.name showGroupsPage yes Coach -> Plan -> Groups -> Select any group -> Click Enroll Learners

Reviewer guidance

Please Follow the table for reviewing the refactored routes.

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Signed-off-by: shivangrawat30 <[email protected]>
@github-actions github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend SIZE: small labels Feb 18, 2024
@MisRob MisRob self-requested a review February 19, 2024 08:50
@MisRob MisRob self-assigned this Feb 19, 2024
Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ShivangRawat30 for your continued work. Code changes make sense and I previewed on my local Kolibri. No issues observed.

Completely up to you, just wanted to mention that opening PRs for around max 5 routes works really well on my side. I'm able to review and test much faster.

@MisRob
Copy link
Member

MisRob commented Feb 22, 2024

And thank you for taking such a good care of testing instructions, that's very helpful too.

@MisRob MisRob merged commit ebeea08 into learningequality:develop Feb 22, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend SIZE: small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants