Distributed error reporting: Setting up the database that stores all the errors #12250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
DEV: backend
Build Artifacts
|
akolson
reviewed
Jun 10, 2024
kolibri/core/errorreports/apps.py
Outdated
| label = "errorreports" | ||
| verbose_name = "Kolibri ErrorReports" | ||
|
|
||
| def ready(self): |
There was a problem hiding this comment.
There's probably no use case for this method. However if there is, then its worth changing its body from ... to pass that is more explicit
There was a problem hiding this comment.
I thought both were the same thing!
There was a problem hiding this comment.
Pass is more explicit. ... could mean a host of things.
It goes back to my earlier question. Do we really need the ready method?
There was a problem hiding this comment.
Not now, some apps inside core had it defined this way with pass. So I just copy-pasted
There was a problem hiding this comment.
I thinks it's best we remove it as it won't really be necessary.
akolson
approved these changes
Jun 11, 2024
akolson
merged commit e5f2b4c
into
learningequality:distributed-error-reporting
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
errorreportsapp and add it to INSTALLED_APPSerrorreportsdatabase name to the additional sqlite database…
References
Fixes #12244
…
Reviewer guidance
I created a TestModel in errorreports app, which I then migrated and tested in a shell that the creation of objects with that model is written to errorreports.sqlite3 and not any other databases.
…
Testing checklist
PR process
Reviewer checklist
yarnandpip)