Refactored HomePage route handler to fetch initClassInfo and getFacil… #12358
Conversation
…ities data individually
github-actions
bot
added
APP: Coach
|
Hi @shubh1007, this is great! I can see you grasped the problem and the strategy for solving it, thanks a lot. This will really help us to unblock some important work. Leaving just a few details, but overall looks really good. Do you wish to continue with some other routes from this file? If so, would you push them to this PR as well or would you rather work in a new one? Note that I'm mostly offline until July 8 - just chiming in on this issue to confirm that you can continue if you'd like, and on some days I will be available to answer questions. |
Build Artifacts
|
|
Thanks for following up @shubh1007. I will finish review when I'm back online next week. Meanwhile, I feel confident that we're on the same page about this task so feel free to continue working on other routes if you'd like (or please message us if you don't want to work on more so we know we should re-assign) |
and remove hardcoded colors in favor of theme tokens. Fixes learningequality#12425
This fixes vue/require-v-for-key 'Elements in iteration expect to have 'v-bind:key' directives.' lint error and ensures efficient Vue updates.
There's no PageNames.HomeActivityPage
There was a problem hiding this comment.
@shubh1007 Thank you. I pushed two last tweaks. See commit messages to understand. As soon as checks pass, we will merge.
Summary
This is the continuation of the refactoring process for the coach page, transitioning from a global route handler to local route handlers. #11219
References
List of all planRoutes:
Reviewer guidance
Please follow the table for reviewing the refactored routes.
Testing checklist
PR process
Reviewer checklist