Coach questions preview: Fix background and selection colors + resolve linter errors #12427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and remove hardcoded colors in favor of theme tokens. Fixes learningequality#12425
This fixes vue/require-v-for-key 'Elements in iteration expect to have 'v-bind:key' directives.' lint error and ensures efficient Vue updates.
github-actions
bot
added
APP: Coach
MisRob
requested review from
nucleogenesis,
AllanOXDi and
pcenov
and removed request for
pcenov
Build Artifacts
|
MisRob
changed the title
There was a problem hiding this comment.
Code changes LGTM - thanks Misha! I added @pcenov as a reviewer here to get his thoughts on the updates and if this sufficiently addresses the related issue
Comment on lines
-428
to
-435
|
|
||
| &:hover { | ||
| background-color: white; | ||
| } | ||
|
|
||
| &.selected { | ||
| background-color: white; | ||
| } |
There was a problem hiding this comment.
I did this in a bit of a rush 😅 - thanks for the reminder on $computedClass 😃
|
Hi @nucleogenesis I noticed that this fix is not in https://github.com/learningequality/kolibri/releases/tag/v0.17.0-beta2 - could you check why? Thanks! |
|
As far as I can see the fix is present in 0.17b3, so we should be good 🙂 
|
|
Hi @radinamatic and @nucleogenesis - the fix is still not present in 0.17.0-rc2: 2024-08-02_16-12-27.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After (see the linked issue for 'before')
References
Closes #12425
Reviewer guidance
Preview a quiz with several questions as a coach in Plan.
Testing checklist
Critical user journeys are covered by Gherkin storiesCritical and brittle code paths are covered by unit testsPR process
If this is an important user-facing change, PR or related issue has a 'changelog' labelIf this includes an internal dependency change, a link to the diff is providedReviewer checklist
yarnandpip)