Search is only working on new page loads #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d bad hardcoding it inside a component) and add useEffect to re-apply search in first render. The current plugin uses a mutation observer that is loaded with a DOMContentLoaded event that does not fire on the pure JS page transitions in Gatsby. So when you navigate to another page, the plugin does not try to find the search input box.
…sing prettier/eslint?
… and… I do not understand why/how is this being used. I guess it’s a C&P error from setting the prop in the component just before.
…ience with Gatsby) but you are using order as the key to an iteration in React and this is not fine for React and causes all sort of problems. See https://reactjs.org/docs/lists-and-keys.html#keys.
…etting any key. Newsletters won’t work of course.
|
Deploy request for happy-jackson-1b6bb8 accepted. Accepted with commit abc910f https://app.netlify.com/sites/happy-jackson-1b6bb8/deploys/608d3a7294378f0007ca57a2 |
plhnk
approved these changes
May 3, 2021
|
Thanks for merging :D But it's failing in production because it can resolve the process.env variable :'( I'll send a PR hardcoding it, that way it will be safer than rely on configuration files. |
|
ah — I set it in Netlify...that should have solved it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This should fix this and this. And some other small things (in the commit messages). I can split/format the PR any way you like :D
The search issue is due to this. I would remove the plugin because it's doing almost nothing right now and use custom code. I've replaced the harcoded key with a variable:
process.env.ALGOLIA_KEYso for it to work you have to define it in your properties (or hardcode it again, it's safe to leak as it's designed to be used in frontend apps).If you have any doubts/issues, please let me know! :)
With the key it should work like this: