Serialize blinded Trampoline hops #3007
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3007 +/- ##
==========================================
- Coverage 89.65% 89.63% -0.02%
==========================================
Files 126 126
Lines 102676 102747 +71
Branches 102676 102747 +71
==========================================
+ Hits 92054 92101 +47
- Misses 7905 7917 +12
- Partials 2717 2729 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lightning/src/ln/msgs.rs
Outdated
| @@ -1767,6 +1768,21 @@ mod fuzzy_internal_msgs { | |||
| outgoing_cltv_value: u32, | |||
| /// The node id to which the trampoline node must find a route | |||
| outgoing_node_id: PublicKey, | |||
| }, | |||
| #[allow(unused)] | |||
| BlindedForward { | |||
There was a problem hiding this comment.
Can we get some docs, what does BlindedForward and BlindedReceive actually mean?
arik-so
force-pushed
the
arik/trampoline/2024-04-trampoline-blinded-hop-serialization
branch
from
67ecd63
to
4b631d6
Compare
|
CI is quite sad. |
arik-so
force-pushed
the
arik/trampoline/2024-04-trampoline-blinded-hop-serialization
branch
2 times, most recently
from
e3c86f7
to
4c785b5
Compare
|
Feel free to squash before any reviewers take a big look. |
arik-so
force-pushed
the
arik/trampoline/2024-04-trampoline-blinded-hop-serialization
branch
from
4c785b5
to
16d1ba1
Compare
| /// List of blinded path options the last trampoline hop may choose to route through. | ||
| payment_paths: Vec<BlindedPath>, | ||
| /// If applicable, features of the BOLT12 invoice being paid. | ||
| invoice_features: Option<Bolt12InvoiceFeatures> |
There was a problem hiding this comment.
Are you sure this is supposed to be a Bolt12InvoiceFeatures and not a BlindedPathFeatures? I mean it makes sense just want to double-check.
There was a problem hiding this comment.
by BlindedPathFeatures do you mean BlindedHopFeatures?
lightning/src/ln/msgs.rs
Outdated
| @@ -1767,6 +1768,21 @@ mod fuzzy_internal_msgs { | |||
| outgoing_cltv_value: u32, | |||
| /// The node id to which the trampoline node must find a route | |||
| outgoing_node_id: PublicKey, | |||
| }, | |||
| #[allow(unused)] | |||
| BlindedForward { | |||
arik-so
force-pushed
the
arik/trampoline/2024-04-trampoline-blinded-hop-serialization
branch
from
53b7f63
to
b9f002e
Compare
Add
BlindedForwardandBlindedReceivevariants toOutboundTrampolinePayload.