Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Splicing] Signer extended with method to sign prev funding transaction input #3316

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

optout21
Copy link
Contributor

Fixes #3312 . (#1621 )

New method to sign an input of a transaction with our funding key.
Used for splicing, when signing the previous funding transaction. The previous funding transaction becomes an input to the new funding transaction, and it is a multisig, which we also need to sign.

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 89.62%. Comparing base (02973ea) to head (8cfd5d9).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/sign/mod.rs 0.00% 20 Missing ⚠️
lightning/src/util/test_channel_signer.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3316      +/-   ##
==========================================
- Coverage   89.65%   89.62%   -0.03%     
==========================================
  Files         126      126              
  Lines      102532   102763     +231     
  Branches   102532   102763     +231     
==========================================
+ Hits        91922    92104     +182     
- Misses       7887     7936      +49     
  Partials     2723     2723              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lightning/src/sign/ecdsa.rs Outdated Show resolved Hide resolved
lightning/src/sign/ecdsa.rs Outdated Show resolved Hide resolved
@optout21 optout21 marked this pull request as ready for review September 18, 2024 15:04
@jkczyz jkczyz self-requested a review September 19, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Splicing] Signing utility for splicing
2 participants