New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mv uility funcs #45

Merged

jho44 merged 4 commits into main from mv-uility-funcs

Aug 3, 2023

Collaborator

jho44 commented Aug 3, 2023

move sanitize and twilio stuff into lib/src
add auth to twilio funcs
add tests for twilio endpoint

jho44 added 4 commits

August 3, 2023 04:11


          fix addKid + mv sanitize

a9be0a5


          auth twilio

0540b7c


          twilio tests

83a7b0d


          cleanup

f886565

Owner

lilith commented Aug 3, 2023 via email

Lgtm

On Thu, Aug 3, 2023, 12:06 AM Jessica Ho ***@***.***> wrote: - move sanitize and twilio stuff into lib/src - add auth to twilio funcs - add tests for twilio endpoint ------------------------------ You can view, comment on, or merge this pull request online at: #45 Commit Summary - a9be0a5 <a9be0a5> fix addKid + mv sanitize - 0540b7c <0540b7c> auth twilio - 83a7b0d <83a7b0d> twilio tests File Changes (18 files <https://github.com/lilith/playdate/pull/45/files>) - *M* README.md <https://github.com/lilith/playdate/pull/45/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5> (3) - *M* playwright.config.ts <https://github.com/lilith/playdate/pull/45/files#diff-f679bf1e58e8dddfc6cff0fa37c8e755c8d2cfc9e6b5dc5520a5800beba59a92> (2) - *M* prisma/seed.ts <https://github.com/lilith/playdate/pull/45/files#diff-25916e4beee74957726a7a074b682a3761a114d8115673d94cec96579c58d05b> (78) - *M* src/hooks.server.ts <https://github.com/lilith/playdate/pull/45/files#diff-b5aa13ce0a61c3f166000471d0729aa6a8e57292fdbd8d88452443502e4b9a4a> (8) - *M* src/lib/server/db.ts <https://github.com/lilith/playdate/pull/45/files#diff-22feae00926a1a5c60006c5be5da6fe4a74b70608a5b718fa41a484c8273f544> (5) - *A* src/lib/server/sanitize.ts <https://github.com/lilith/playdate/pull/45/files#diff-a02036c4b1e124399f5b9da02851a6d1b2e59b0ebaf903873ac1e62382df781c> (54) - *M* src/lib/server/shared.ts <https://github.com/lilith/playdate/pull/45/files#diff-ba1c7192d15f62ab1fc0385adff5ae63f73d299e379735cce9e6242ee2271ed0> (1) - *A* src/lib/server/twilio.ts <https://github.com/lilith/playdate/pull/45/files#diff-f9ae1b943c416cb1057474452fde0e55cc1c537729a88cfeefa14ce7c95bb799> (231) - *M* src/routes/+layout.server.ts <https://github.com/lilith/playdate/pull/45/files#diff-49dc14268e89f5a2bf852134625940dc89992c8e534f34bbbacc1106f1dac4b1> (1) - *M* src/routes/+page.svelte <https://github.com/lilith/playdate/pull/45/files#diff-1e1270da740e81dd13f8a65057582b0fce8a5fb3817ef913f3e90d7f82c4e9df> (18) - *M* src/routes/calendar/+page.svelte <https://github.com/lilith/playdate/pull/45/files#diff-e975e2ea20d4b9c8bb8f2b78afd62926c77f37f0326f27d680a7f97747452ed9> (11) - *M* src/routes/circle/+page.svelte <https://github.com/lilith/playdate/pull/45/files#diff-cb0d35f9ff98be28caf5b9ae2bc82c7d24ff21f25bd351842f90b2f1b54ef7cc> (2) - *M* src/routes/household/+page.svelte <https://github.com/lilith/playdate/pull/45/files#diff-042d5eca6b5599076babe0b69703289e210320bc7b3d704366ed18ae52a084fc> (21) - *M* src/routes/profile/+page.svelte <https://github.com/lilith/playdate/pull/45/files#diff-efa46280002ff2d039ee330f0dbb33dfeb2a9d9d586316eb1213311c1c55889e> (5) - *M* src/routes/sanitize/+server.ts <https://github.com/lilith/playdate/pull/45/files#diff-443b9a564941d3093047d07270bd8ad0edffa6e628e7d73f3997928e486cfb07> (69) - *M* src/routes/twilio/+server.ts <https://github.com/lilith/playdate/pull/45/files#diff-d5618858b47ac71c4240045b061cbd2919ada987efcc0b0b530b5551d7110959> (164) - *M* tests/db.spec.ts <https://github.com/lilith/playdate/pull/45/files#diff-f60aa1ef5db26f64995145d7de5548e4721d337e8195b1e0f8b8f82ff49b5e90> (31) - *A* tests/twilio.spec.ts <https://github.com/lilith/playdate/pull/45/files#diff-7da36a24e3c16bd975f4755bf4482d3bb7c6c659e7f6040b414b2fc79806ef13> (137) Patch Links: - https://github.com/lilith/playdate/pull/45.patch - https://github.com/lilith/playdate/pull/45.diff — Reply to this email directly, view it on GitHub <#45>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA2LH2PAJ2E4DIXZB6RQTTXTM5URANCNFSM6AAAAAA3CH6CB4> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

Collaborator Author

jho44 commented Aug 3, 2023 •

edited

Loading

Lgtm

Thanks! Btw the reason tests are failing is bc tables aren't being created before the tests are run. I can't edit .github/ since I don't have workflow scope so I'll leave it to you?

jho44 merged commit d5eb083 into main

1 of 3 checks passed

jho44 deleted the mv-uility-funcs branch

August 3, 2023 06:12

Owner

lilith commented Aug 3, 2023

Makes sense, the yarn postinstall just calls prisma generate. Let me try to fix your permissions so you can edit .github

Owner

lilith commented Aug 3, 2023 via email

Are you sure you don't have permissions? I don't see anything that could be blocking it. What message do you get?

On Thu, Aug 3, 2023, 12:12 AM Jessica Ho ***@***.***> wrote: Merged #45 <#45> into main. — Reply to this email directly, view it on GitHub <#45 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA2LHYB3KIBWORDPLBD6TDXTM6MRANCNFSM6AAAAAA3CH6CB4> . You are receiving this because you commented.Message ID: ***@***.***>

Collaborator Author

jho44 commented Aug 6, 2023

Are you sure you don't have permissions? I don't see anything that could be blocking it. What message do you get?

Oh geez sorry. I didn't get a notif about this 😬 i found the cause! gitpod had secondary permissions about what a user can do to a GitHub repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet