Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TF-3113 Fix cannot empty spam on mobile #3129

Merged
merged 3 commits into from
Sep 10, 2024
Merged

TF-3113 Fix cannot empty spam on mobile #3129

merged 3 commits into from
Sep 10, 2024

Conversation

dab246
Copy link
Member

@dab246 dab246 commented Sep 4, 2024 •
edited
Loading

Issue

#3113

Reproduced

reproduced.webm

Root cause

  • SendPort.send() of isolate flutter only supports some objects
  • Network connection objects cannot be shared between isolates.
Screenshot 2024-09-04 at 10 41 49

Resolved

demo-spam.webm

@dab246 dab246 requested a review from hoangdat September 4, 2024 05:28
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

This PR has been deployed to https://linagora.github.io/tmail-flutter/3129.

@tddang-linagora tddang-linagora mentioned this pull request Sep 5, 2024
Open
@dab246 dab246 mentioned this pull request Sep 5, 2024
Merged
@tddang-linagora tddang-linagora mentioned this pull request Sep 5, 2024
Merged
@dab246 dab246 mentioned this pull request Sep 9, 2024
Open
@hoangdat hoangdat merged commit f2a2097 into refactor Sep 10, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangdat hoangdat hoangdat approved these changes

@tddang-linagora tddang-linagora tddang-linagora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dab246 @hoangdat @tddang-linagora