Skip to content

Commit

Permalink
Cleanup of Clang-Tidy warnings in Applewin
Browse files Browse the repository at this point in the history
  • Loading branch information
maxolasersquad committed Oct 24, 2023
1 parent eb1f22e commit 7998ca9
Show file tree
Hide file tree
Showing 5 changed files with 109 additions and 78 deletions.
36 changes: 36 additions & 0 deletions .clang-tidy
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
---
Checks: 'clang-diagnostic-*,clang-analyzer-*,bugprone-bool-pointer-implicit-conversion,readability-implicit-bool-cast,readability-simplify-boolean-expr,modernize-use-bool-literals'
WarningsAsErrors: ''
HeaderFilterRegex: ''
AnalyzeTemporaryDtors: false
CheckOptions:
- key: cert-dcl16-c.NewSuffixes
value: 'L;LL;LU;LLU'
- key: cert-oop54-cpp.WarnOnlyIfThisHasSuspiciousField
value: '0'
- key: cppcoreguidelines-explicit-virtual-functions.IgnoreDestructors
value: '1'
- key: cppcoreguidelines-non-private-member-variables-in-classes.IgnoreClassesWithAllMemberVariablesBeingPublic
value: '1'
- key: google-readability-braces-around-statements.ShortStatementLines
value: '1'
- key: google-readability-function-size.StatementThreshold
value: '800'
- key: google-readability-namespace-comments.ShortNamespaceLines
value: '10'
- key: google-readability-namespace-comments.SpacesBeforeComments
value: '2'
- key: modernize-loop-convert.MaxCopySize
value: '16'
- key: modernize-loop-convert.MinConfidence
value: reasonable
- key: modernize-loop-convert.NamingStyle
value: CamelCase
- key: modernize-pass-by-value.IncludeStyle
value: llvm
- key: modernize-replace-auto-ptr.IncludeStyle
value: llvm
- key: modernize-use-nullptr.NullMacros
value: 'NULL'
...

2 changes: 1 addition & 1 deletion INSTALL.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
#### Debian / Ubuntu / RetroPie

```bash
sudo apt-get install git libzip-dev libsdl1.2-dev libsdl-image1.2-dev libcurl4-openssl-dev zlib1g-dev imagemagick
sudo apt-get install git libzip-dev libsdl1.2-dev libsdl-image1.2-dev libcurl4-openssl-dev zlib1g-dev libtime-parsedate-perl imagemagick
```

#### Fedora / RHEL / CentOS
Expand Down
3 changes: 3 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,9 @@ $(BUILDDIR)/%.$(XPMEXT): $(RESDIR)/%.$(IMGEXT)
$(TARGETDIR)/%.$(SYMEXT): $(RESDIR)/%.$(SYMEXT)
cp $< $@

ctidy: resources
clang-tidy $(SRCDIR)/*.$(SRCEXT) $(SRCDIR)/Debugger/*.$(SRCEXT) -- $(CFLAGS) $(INC) 2>&1 | tee clang-tidy.log

install: all
install -D --target-directory "$(DESTDIR)/$(BINDIR)" build/$(BINDIR)/$(TARGET)
install -D --target-directory "$(DESTDIR)/$(DATADIR)" build/$(DATADIR)/Master.dsk
Expand Down
3 changes: 0 additions & 3 deletions inc/AppleWin.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@

#define FTP_SEPARATOR TEXT('/')

// let it be our second version!
#define LINAPPLE_VERSION 2

#include <curl/curl.h>

extern char *g_pAppTitle;
Expand Down
Loading

0 comments on commit 7998ca9

Please sign in to comment.