feat: support to use pipewire #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsien
reviewed
Jul 18, 2023
audio1/audio.go
Outdated
| var errBuf bytes.Buffer | ||
|
|
||
| // 如果pulseaudio 音频服务启动失败，尝试去启动pipewire音频服务 |
There was a problem hiding this comment.
直接判断有 pipewire.service 还是 pulseaudio.service 呗
There was a problem hiding this comment.
可以先 exec.Command(cmdSystemctl, "--user", "list-unit-files", "pulseaudio.service")，通过返回 0/1 确定服务是否存在，再启动对应服务。
dengbo11
force-pushed
the
fix-bug
branch
3 times, most recently
from
a222441
to
b89b281
Compare
audio moudule support to use pipewire Log:
there is already a retry mechanism for using systemd to start services so don't need to manual to retry Log:
YukariChiba
approved these changes
Jul 19, 2023
Decodetalkers
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
audio moudule support to use pipewire
Log: