Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 解决dde-pixmix在root下执行崩溃的问题 #377

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

fly602
Copy link

@fly602 fly602 commented Aug 12, 2024

解决dde-pixmix在root下执行崩溃的问题
Issue: linuxdeepin/developer-center#10310

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 更改了日志记录的输出方式,从文件记录更改为系统日志journal。需要确认这是否是预期的日志策略。
  • 添加了一个命令行选项"-o/--output",但未在代码中看到对该选项的处理逻辑。

是否建议立即修改:

  • 是,需要确认日志策略的更改是否符合项目需求,并且确保添加了相应的日志处理逻辑。同时,应该检查是否有必要在代码中实现对新添加选项的处理。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caixr23, fly602

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fly602
Copy link
Author

fly602 commented Aug 12, 2024

/forcemerge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 12, 2024

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit 3db5bd1 into linuxdeepin:master Aug 12, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants