Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the album permission control problem #259

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

add-uos
Copy link
Contributor

@add-uos add-uos commented Sep 23, 2024

fix the album permission control problem when import photo

Log: fix the album permission control problem when import photo
Bug: https://pms.uniontech.com/bug-view-270731.html

@@ -1329,19 +1329,25 @@ void MainWindow::onImprotBtnClicked()
if (mode != QDialog::Accepted) {
return;
}
const QStringList &file_list = dialog.selectedFiles();
const QStringList &file_list = dialog.selectedFiles();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多了空格

fix the album permission control problem  when import photo

Log: fix the album permission control problem  when import photo
Bug: https://pms.uniontech.com/bug-view-270731.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • pathControl函数中,使用了QDBus进行通信,但没有处理可能出现的异常情况。
  • pathControl函数的注释说明不够详细,应该提供更详细的说明,包括函数的输入输出、异常情况等。
  • pathControl函数中的代码重复性较高,可以考虑将其重构为一个通用的文件路径检查函数。
  • onImprotBtnClicked函数中的代码重复性较高,可以考虑将其重构为一个通用的文件导入函数。
  • closeEvent函数中调用了saveWindowState函数,但没有检查其返回值,可能会导致未处理的初始化状态。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos, lzwind

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@add-uos
Copy link
Contributor Author

add-uos commented Sep 24, 2024

/merge

@deepin-bot deepin-bot bot merged commit 87af323 into linuxdeepin:release/eagle Sep 24, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants