Type check insertvalue operands

llir · Feb 23, 2019 · 47f6d07 · 47f6d07
1 parent d51964f
commit 47f6d07
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/ir/inst_aggregate.go b/ir/inst_aggregate.go
@@ -92,6 +92,10 @@ type InstInsertValue struct {
 // NewInsertValue returns a new insertvalue instruction based on the given
 // aggregate value, element and indicies.
 func NewInsertValue(x, elem value.Value, indices ...uint64) *InstInsertValue {
+	elemType := aggregateElemType(x.Type(), indices)
+	if !elemType.Equal(elem.Type()) {
+		panic(fmt.Errorf("insertvalue elem type mismatch, got %v, want %v", elem.Type(), elemType))
+	}
 	inst := &InstInsertValue{X: x, Elem: elem, Indices: indices}
 	// Compute type.
 	return inst