Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic if trunc operands are not compatible #71

Merged
merged 1 commit into from
Feb 25, 2019
Merged

Conversation

pwaller
Copy link
Member

@pwaller pwaller commented Feb 24, 2019

  • Support vector and int typed arguments.
  • Add a table driven test for the different cases.

I've tried my best to make the error messages informative and consistent
with other error messages, but further improvements are welcomed -
please also feel free to take ownership of the branch and tweak the
messages if appropriate.

Updates #65.

Subsumes part of PR #69.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 68.151% when pulling 5709403 on type-check-trunc into 10a64da on master.

@coveralls
Copy link

coveralls commented Feb 24, 2019

Coverage Status

Coverage increased (+0.07%) to 68.34% when pulling 2e3b0c1 on type-check-trunc into 10a64da on master.

* Support vector and int typed arguments.
* Add a table driven test for the different cases.

I've tried my best to make the error messages informative and consistent
with other error messages, but further improvements are welcomed -
please also feel free to take ownership of the branch and tweak the
messages if appropriate.

Updates #65.

Subsumes part of PR #69.
Copy link
Member

@mewmew mewmew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mewmew mewmew merged commit 759aaa1 into master Feb 25, 2019
@pwaller pwaller deleted the type-check-trunc branch February 25, 2019 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants