Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jenkins] Coverage bot: Remove cross-project-tests #46

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gulfemsavrun
Copy link

@gulfemsavrun gulfemsavrun commented Sep 8, 2023

Directory coverage is recently enabled in https://reviews.llvm.org/D158703, and the following file shows up at the top level because cross-project-tests is also built in the coverage build:
cross-project-tests/debuginfo-tests/llvm-prettyprinters/gdb/llvm-support.cpp
This patch removes cross-project-tests from the project list.

Directory coverage is recently enabled in https://reviews.llvm.org/D158703
The following file shows up at the top level because cross-project-tests is
also built in the coverage build:
`cross-project-tests/debuginfo-tests/llvm-prettyprinters/gdb/llvm-support.cpp`
This patch removes cross-project-tests from the project list.

Differential Revision: https://reviews.llvm.org/D159469
@yhgu2000
Copy link

yhgu2000 commented Sep 9, 2023

I don't know if disabling the cross-project-test affects the coverage metrics. Will it be better if we use the --ignore-filename-regex optior to just hide it in the report? In that case, we need to modify the Python script instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants