Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Remove no longer required secret push token for Jenkins setups #9317

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

b-fein
Copy link
Contributor

@b-fein b-fein commented Sep 16, 2024

Checklist

General

Server

Changes affecting Programming Exercises

  • I tested all changes and their related features with all corresponding user types on a test server configured with Gitlab and Jenkins.

Motivation and Context

Since #6682 the builds are no longer triggered in Jenkins from GitLab directly. Instead, Artemis triggers the build by using the regular API authentication of Jenkins.
The secret token was only used to allow GitLab to trigger builds directly in Jenkins. Since this feature is no longer used it can be removed.
It also does not make sense to keep it since it is not required for LocalVC+Jenkins setups.

Description

Removed references to the no longer needed secret-push-token config option.

As should be clear from the server code changes, the secret token is only used when creating the initial build plan. When triggering builds in the Jenkins, Artemis does not use it.

Steps for Testing

Prerequisites:

  • a GitLab+Jenkins or LocalVC+Jenkins setup
  1. Create a new programming exercise.
  2. When making changes to the template or solution repositories the Jenkins build should run and updated results show up in Artemis.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Test Coverage

unchanged

Screenshots

n/a

@coderabbitai ignore

@github-actions github-actions bot added tests server Pull requests that update Java code. (Added Automatically!) documentation config-change Pull requests that change the config in a way that they require a deployment via Ansible. template labels Sep 16, 2024
@b-fein b-fein changed the title Development: Remove no longer required secret push token for GitLab setups Development: Remove no longer required secret push token for Jenkins setups Sep 16, 2024
@dfuchss
Copy link
Contributor

dfuchss commented Sep 16, 2024

I'll test the PR asap

@b-fein b-fein marked this pull request as ready for review September 16, 2024 10:46
@b-fein b-fein requested a review from a team as a code owner September 16, 2024 10:47
dfuchss
dfuchss previously approved these changes Sep 16, 2024
Copy link
Contributor

@dfuchss dfuchss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense.

JohannesWt
JohannesWt previously approved these changes Sep 18, 2024
Copy link
Contributor

@JohannesWt JohannesWt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code 👍

@b-fein b-fein dismissed stale reviews from JohannesWt and dfuchss via 07937c9 September 21, 2024 08:48
@@ -691,6 +691,18 @@ Start Jenkins
user: your.chosen.username
password: your.chosen.password

11. In a local setup, you have to disable CSRF otherwise some API endpoints will return HTTP Status 403 Forbidden.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this is not new, but got lost when removing the secret push token section in #9266.

Copy link
Contributor

@magaupp magaupp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore component:Programming config-change Pull requests that change the config in a way that they require a deployment via Ansible. documentation jenkins/gitlab ready for review server Pull requests that update Java code. (Added Automatically!) template tests
Projects
Status: Ready For Review
Development

Successfully merging this pull request may close these issues.

5 participants