Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-45273: Expand ap_pipe section of Science Pipelines Software Paper #8

Merged
merged 4 commits into from
Aug 15, 2024

Conversation

kfindeisen
Copy link
Collaborator

@kfindeisen kfindeisen commented Aug 14, 2024

This PR fleshes out the description of ap_pipe, and adds stubs for ap_association and alert-packet.

Built document is at https://pstn-019.lsst.io/v/DM-45273/.

These components are AP-only, just like focal plane calibration is
DRP-only, so it makes sense to group them in the middle of the paper.
These labels will make it easier for contributers to make coarse section
references. For consistency, labels use the name of the section's .tex
file wherever possible. The exception is afw.tex, where the "sec:afw"
label already belongs to one of its subsections.
@kfindeisen kfindeisen marked this pull request as ready for review August 14, 2024 21:29
Copy link

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

I'm not sure whether we'll retain the phrase "measurement plugins" (by defining it earlier) or replace it throughout with something more descriptive, but that can be handled across many sections in a later pass. Other than that I don't see anything I'd be inclined to change.

@kfindeisen
Copy link
Collaborator Author

kfindeisen commented Aug 15, 2024

I would think it would be very hard to write Section 6 without using that phrase...

@kfindeisen kfindeisen merged commit 4992f45 into main Aug 15, 2024
2 checks passed
@kfindeisen kfindeisen deleted the tickets/DM-45273 branch August 15, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants