Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interaction to open visualizations in full view #364

Open
wants to merge 37 commits into
base: master
Choose a base branch
from

Conversation

jerrysong1324
Copy link
Contributor

@jerrysong1324 jerrysong1324 commented Apr 18, 2021

TODO:

  • Disable Keyboard Shortcuts (probably in frontend)
  • Documentation / Tests

Overview

Add interaction to open visualizations in full view. lux-org/lux-widget#45
Linked to lux-org/lux-widget#80

Changes

  • Set up backend calls to give graphSpec on full screen toggle.
  • Added functions to re-run code inputed by user
  • Switched lux.plotting_style default to not none.
  • Output error message when code does not return valid spec

Example Output

https://www.loom.com/share/1c38c3ae768c488ea9860ea1a766c015

@dorisjlee
Copy link
Member

Thanks @jerrysong1324! This looks like a great first start. Here are a couple of suggestions on possible ways of improving the UI:

  • I've noticed that some of the code is overflowing in the editor. I'm wondering if we could wrap the text or auto-indent the code in some ways (maybe via autopep8 or black) so that we don't have to scroll to edit the charts.
  • It would be great if we could keep a fixed-size div for the chart itself. That way the buttons won't move around as much when it is being rendered, or when the error shows up. It would also be helpful to show some type of loading button after clicking the Update button.
  • I still think that the two visualization editor and button are a bit confusing to a new user. One thing that might help is describing what the Visualization Editor and Style Editor does, in place of the current titles. We could also try to more explicitly tie together each of the buttons with the editor field, either by putting them more closely in proximity or via some colors. Let's brainstorm and revisit this once the first two UI changes are addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants