Remove hard-coded suppression of GraalVM warnings in favor of documen…

…tation on how to silence them if desired
mablhq · Jul 28, 2023 · 2feb59b · 2feb59b
1 parent f08f9d5
commit 2feb59b
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 3 deletions.
diff --git a/src/main/java/com/mabl/net/proxy/ReloadablePacInterpreter.java b/src/main/java/com/mabl/net/proxy/ReloadablePacInterpreter.java
@@ -17,8 +17,13 @@
  * <p>
  * After creating a {@link ReloadablePacInterpreter}, use the {@link #reload()} method to immediately reload the PAC.
  * Alternatively, use the {@link #start(Duration)} method to begin automatic reloads and the {@link #stop()} method to terminate the reload timer.
+ * </p>
+ * <p>
+ * To silence GraalVM warnings set the "polyglot.engine.WarnInterpreterOnly" system property to "false" e.g. -Dpolyglot.engine.WarnInterpreterOnly=false
+ * </p>
  *
  * @see "https://developer.mozilla.org/en-US/docs/Web/HTTP/Proxy_servers_and_tunneling/Proxy_Auto-Configuration_PAC_file"
+ * @see "https://www.graalvm.org/latest/reference-manual/js/FAQ/#warning-implementation-does-not-support-runtime-compilation"
  */
 public class ReloadablePacInterpreter implements PacInterpreter {
     private static final Logger logger = LoggerFactory.getLogger(ReloadablePacInterpreter.class);

diff --git a/src/main/java/com/mabl/net/proxy/SimplePacInterpreter.java b/src/main/java/com/mabl/net/proxy/SimplePacInterpreter.java
@@ -18,8 +18,12 @@
 
 /**
  * An interpreter for Proxy Auto-Configuration files/URLs.
+ * <p>
+ * To silence GraalVM warnings set the "polyglot.engine.WarnInterpreterOnly" system property to "false" e.g. -Dpolyglot.engine.WarnInterpreterOnly=false
+ * </p>
  *
  * @see "https://developer.mozilla.org/en-US/docs/Web/HTTP/Proxy_servers_and_tunneling/Proxy_Auto-Configuration_PAC_file"
+ * @see "https://www.graalvm.org/latest/reference-manual/js/FAQ/#warning-implementation-does-not-support-runtime-compilation"
  */
 public class SimplePacInterpreter implements PacInterpreter {
     private static final String PAC_UTILS_PATH = "/pacUtils.js";
@@ -63,9 +67,6 @@ private static String validatePac(final String pac) {
 
     private static Engine initializeEngine() {
         return Engine.newBuilder()
-                // Silence GraalVM warnings
-                // See: https://www.graalvm.org/latest/reference-manual/js/FAQ/#warning-implementation-does-not-support-runtime-compilation
-                .option("engine.WarnInterpreterOnly", "false")
                 .build();
     }
 

diff --git a/src/test/java/com/mabl/net/proxy/PacInterpreterTest.java b/src/test/java/com/mabl/net/proxy/PacInterpreterTest.java
@@ -4,6 +4,7 @@
 import io.undertow.Undertow;
 import io.undertow.util.Headers;
 import org.junit.After;
+import org.junit.Before;
 
 import java.io.BufferedWriter;
 import java.io.File;
@@ -25,6 +26,11 @@ abstract public class PacInterpreterTest {
     protected Undertow pacServer;
     private volatile String pacServerContent;
 
+    @Before
+    public void silenceGraalvmWarnings() {
+        System.setProperty("polyglot.engine.WarnInterpreterOnly", Boolean.TRUE.toString());
+    }
+
     @After
     public void tearDown() {
         if (pacServer != null) {