Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevContainer > Node 14 to 18 LTS #4170

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

rafaelstz
Copy link
Member

Node 14 is supported but not recommended, since it's not been maintained anymore.

PWA Studio supports Node 18 LTS, an actively supported version. Ref: https://endoflife.date/nodejs

Screenshot 2023-09-20 135022

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Sep 20, 2023

Fails
🚫

node failed.

🚫 A version label is required. A maintainer must add one.
🚫

Unable to build scaffolded project.

yarn build

within a scaffolded project directory failed.
Learn more about Scaffolding at https://magento.github.io/pwa-studio/pwa-buildpack/scaffolding/.

🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or "closes JIRA-<issue_number>" in your PR.

🚫 Missing "Verification Steps" section. Please add it back, with detail.
🚫 Missing "Description" section. Please add it back, with detail.
Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Log

ERROR ON TASK: scaffoldingSucceeds


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against 724e177

glo82145 added a commit that referenced this pull request Sep 2, 2024
* DevContainer > Node 14 to 18 LTS

* Delete .vscode directory

* Update devcontainer.json

---------

Co-authored-by: Rafael Corrêa Gomes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

3 participants