Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update category identifier in useMegaMenuItem.js #4257

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

martinyeboyebo
Copy link

Description

Fix Peregrine Talon by category from menu called useMegaMenuItem by replacing the attribute category_id by category_uid

Related Issue

The categories are not marked as active since their identifier is uid and not id. I correct the identifier so that the categories are marked correctly when you visit one of them.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

devops-pwa-codebuild and others added 4 commits April 2, 2024 10:04
* Updated Changedoc in PWA 14.0.0

* Updated Changedoc in PWA 14.0.0

* Updated Changedoc in PWA 14.0.0

* Updated Changedoc in PWA 14.0.0
The categories are not marked as active since their identifier is uid and not id. I correct the identifier so that the categories are marked correctly when you visit one of them.
@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

🚫 A version label is required. A maintainer must add one.
🚫

Unit tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • packages/peregrine/lib/talons/MegaMenu/__tests__/useMegaMenuItem.spec.js
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or "closes JIRA-<issue_number>" in your PR.

Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Log

ERROR ON TASK: unitTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 39c864b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

4 participants