Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not instruct users to publish assets from other packages #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do not instruct users to publish assets from other packages #3

wants to merge 1 commit into from

Conversation

freekmurze
Copy link

This PR changes the readme so it instructs users to only publish assets by this package.
More info: https://murze.be/2016/04/publishing-package-assets-right-way/

This PR changes the readme so it instructs users to only publish assets by this package.
More info: https://murze.be/2016/04/publishing-package-assets-right-way/
@maknz
Copy link
Owner

maknz commented Jul 5, 2016

We've had countless problems with the --provider option. We used to use that on the main maknz/slack repo but we got complaints of it not working. I could reproduce this locally too (maknz/slack#53).

vendor:publish seems to work all the time which is good, but it's got the downside mentioned above. One suggestion was to tag the config so at least you wouldn't get views and shit getting published from other packages, just the config.

Additionally, are you sure the proxy service provider will work? This user tried it and it didn't work, but the Laravel 5 one directly seemed to work: #1. That of course doesn't help the fact that --provider didn't work at all when I tested a fresh Laravel 5.2 install locally.

Overall I'd like to use --provider but the behaviour is so erratic.

@freekmurze
Copy link
Author

freekmurze commented Jul 5, 2016

This is the first time I've heard of this problem.

Your code does look ok to me.

Try opening an issue at the Laravel framework repo or post this problem at Laraslack to get some help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants