Fix row slicing with sort_and_finalize throw on column slicing when t… #1838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he column group is larger than the segment column size
vasil-pashov
commented
Sep 18, 2024
vasil-pashov
requested review from
alexowens90,
willdealtry and
poodlewars
as code owners
| @@ -1456,6 +1456,14 @@ VersionedItem sort_merge_impl( | |||
| "Finalizing staged data is not allowed with empty staging area" | |||
| ); | |||
|
|
|||
| user_input::check<ErrorCode::E_INVALID_USER_ARGUMENT>( | |||
| write_options.dynamic_schema || pipeline_context->staged_descriptor_->field_count() < write_options.column_group_size, | |||
| "Sorting and finalizing staged data is not implemented in the case when column slicing would appear. The " | |||
There was a problem hiding this comment.
not yet implemented?
we do have a plan to solve this in future
alexowens90
requested changes
Sep 19, 2024
| "input DataFrame has {} fields which is more than the column group size ({}) set in the library options", | ||
| pipeline_context->staged_descriptor_->field_count(), | ||
| write_options.column_group_size | ||
| ); |
There was a problem hiding this comment.
This shouldn't be an error? It should just write segments wider than the lib config setting
| class TestSlicing: | ||
| def test_long_append_segment(self, lmdb_library): | ||
| set_config_int('Merge.SegmentSize', 5) |
There was a problem hiding this comment.
Use a context manager to ensure it is reset at the end of the test:
ArcticDB/python/arcticdb/util/test.py
Line 122 in 008fa54
| assert set(lib.list_symbols()) == set([sym, sym_2]) | ||
|
|
||
| class TestSlicing: |
There was a problem hiding this comment.
Can we also have a test where the individual staged segments are smaller than the segment row count, but when they are compacted they are larger?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…he column group is larger than the segment column size
Reference Issues/PRs
What does this implement or fix?
Any other comments?
Checklist
Checklist for code changes...