fix enable and disable when selectbox destroyed #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marcj , can you please review also this pull request? It's been two months since was opened and i got no feedback. Thank you very much :) |
|
any chance this would get reviewed? It's been 4 months since i opened it. @marcj can You please take a look? |
|
any updates on this ?:D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a continuation of this pull request #150
Seems if the selectbox is disabled and then destroyed, if the selectbox is not enabled and you want to set options on the select and then enable it, seems the attribute "disabled" is not removed.
You can test this here: http://jsfiddle.net/xx97so9m/1/ ( using master branch from github) - This is a demo of the bug .
If needed i can make a demo with the fixed version too.
This solves this issue.
Please let me know what you think. There might be a better way of doing this. Thank you very much