Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move alt text editor to a separate view controller #864

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

j-f1
Copy link
Contributor

@j-f1 j-f1 commented Jan 6, 2023

This definitely needs a design pass on multiple levels but here’s what it looks like right now:

@wayneca
Copy link

wayneca commented Jan 7, 2023

#813 is a bug that this suggestion would address. This is a critical bug. It prevents people from adding alt text to images that visually-impaired people depend upon. If you can, it may be good to put "Accessibility Bug" in the title.

@wayneca
Copy link

wayneca commented Jan 24, 2023

I just noticed that if you add more than one image, it is only the last one that you can't scroll and set the alt text. That is because the app doesn't stay at the bottom if you scroll to the bottom. It bounces back to put the alt text overlay below the region that is shown. So, this looks like it may be a problem caused by adding the overlay bouncing back after scrolling to the bottom. That may be something that could be fixed by a simpler fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants