Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around the hang due to infinite layout shifts #932

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

j-f1
Copy link
Contributor

@j-f1 j-f1 commented Feb 9, 2023

Ref: #705. I have been unable to ever reproduce this hang, but based on an Instruments trace that was sent to me it appears that contentCellFrame was changing repeatedly. Ideally we’d figure out why that is happening and get rid of it. That might require rewriting the table view in SwiftUI though (or maybe replacing the UITableView with a UIScrollView?)

This change does slightly regress the UI because hitting return twice in a row causes the UI to flicker but hitting it once doesn’t. Not sure if that’s ok or not.

What would be best is if someone could get the bug to repro on their device and trace back why the layout is changing.

I don’t know if this will fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant