Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: M -> D native discord edits #819

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

feat: M -> D native discord edits #819

wants to merge 4 commits into from

Conversation

Vyquos
Copy link

@Vyquos Vyquos commented Jul 28, 2022

fixes issue #644.

@Vyquos Vyquos requested a review from a team as a code owner July 28, 2022 20:50
@Vyquos
Copy link
Author

Vyquos commented Jul 28, 2022

A few things to consider:

  1. the edits aren't stored in DiscordBot.store
  2. the db reference of the old matrix event and discord message isn't updated
  3. the old mechanism of deleting and re-sending the edited discord message is kept as a fallback - though I'm not sure that it's necessary

@Miepee
Copy link
Contributor

Miepee commented Aug 4, 2022

Not a reviewer, but what was the reason for bumping the better-discord.js dependency?

@Vyquos
Copy link
Author

Vyquos commented Aug 6, 2022

With 48b0430, the discord.Webhook.editMessage endpoint is added. Because better-discord.js is very outdated (last commit was made >1.5 years ago) i thought I'd bump the version of the dependency to its most recent.
There's only one commit more recent than the one i need (48b0430) anyway.

@Vyquos Vyquos force-pushed the develop branch 2 times, most recently from 6981bcd to 90c5459 Compare October 12, 2022 20:51
Miepee
Miepee reviewed Oct 13, 2022
View reviewed changes
changelog.d/819.feature Outdated Show resolved Hide resolved
@Vyquos
Copy link
Author

Vyquos commented Oct 13, 2022

thanks!

@Miepee
Copy link
Contributor

Miepee commented Nov 3, 2022

With the merge of #858 you probably need to rebase this @Vyquos

@Vyquos
Copy link
Author

Vyquos commented Nov 9, 2022

thanks for the reminder! My private signoff is still valid, right?

@Miepee
Copy link
Contributor

Miepee commented Nov 10, 2022

Am not a maintainer, just some guy trying to help here. Someone from the orga needs to answer that.

@fee1-dead
Copy link

Any updates on this?

Vyquos and others added 4 commits December 3, 2023 15:00
@Vyquos
Change misleading variable name
1c32233 
Rename "editEventId" to "editedEventId" in DiscordBot.edit. The id string that's
handed to the function as an argument is the id of the original message event,
while 'event.event_id' is the actual replace/edit-event.
@Vyquos
Bridge edits to discord webhooks
f8e9449 
Support M->D edit bridging via the native discord webhook endpoint

Fixes issue matrix-org#644
@Vyquos
Add changelog
8098baf
@Vyquos @Miepee
Fix changelog typo
b1f0eed 
Co-authored-by: Miepee <[email protected]>
Signed-off-by: Vyquos <[email protected]>
@Vyquos Vyquos changed the title Bridge matrix edits to native discord edits feat: M -> D native discord edits Dec 3, 2023
@Vyquos Vyquos closed this Dec 3, 2023
@Vyquos
Copy link
Author

Vyquos commented Dec 3, 2023 •
edited
Loading

Accidentally closed this while rebasing. The issue remains. I can't reopen it so I'll open a new one, but I'd be happy to continue working on this PR if the maintainers could reopen this issue.

I just saw that I can just reopen the issue. Oops, my bad.

@Vyquos Vyquos mentioned this pull request Dec 3, 2023
Closed
@Vyquos Vyquos reopened this Dec 3, 2023
@Vyquos
Copy link
Author

Vyquos commented Dec 3, 2023

Any updates on this?

I rebased again, hoping for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Miepee Miepee Miepee left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vyquos @Miepee @fee1-dead