Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply nick pattern to user updates #891

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

TheTechmage
Copy link

When a nickname is updated for a user, and it isn't updated as a GuildMember object, we fail to apply the nick pattern to the Matrix nickname for the ghost user. By using the same logic as the GetUserStateForGuildMember in GetUserStateForDiscordUser, the nickname should now match the nickname pattern. Hopefully this will cut back on nickname changes being echoed out in Matrix channels, when no changes were made in the first place. At the very least, if a prefix/suffix is added to usernames, those should remain on the user at all times now.

Signed-off-by: Colton Wolkins (Laptop) <[email protected]>
When a nickname is updated for a user, and it isn't updated as a
GuildMember object, we fail to apply the nick pattern to the Matrix
nickname for the ghost user. By using the same logic as the
GetUserStateForGuildMember in GetUserStateForDiscordUser, the nickname
should now match the nickname pattern. Hopefully this will cut back on
nickname changes being echoed out in Matrix channels.

Signed-off-by: Colton Wolkins (Laptop) <[email protected]>
Signed-off-by: Colton Wolkins (Laptop) <[email protected]>
@TheTechmage TheTechmage marked this pull request as ready for review July 21, 2023 14:47
@TheTechmage TheTechmage requested a review from a team as a code owner July 21, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant