Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converting src/browser-index.js to typescript #2016

Closed
wants to merge 3 commits into from
Closed

Converting src/browser-index.js to typescript #2016

wants to merge 3 commits into from

Conversation

Aryaman1706
Copy link

@Aryaman1706 Aryaman1706 commented Nov 9, 2021 •
edited by github-actions bot
Loading

Signed-off-by: Aryaman Grover [email protected]

This change is marked as an internal change (Task), so will not be included in the changelog.

@Aryaman1706 Aryaman1706 requested a review from a team as a code owner November 9, 2021 18:56
@SimonBrandner SimonBrandner added the T-Task Tasks for the team like planning label Nov 9, 2021
@Aryaman1706
Copy link
Author

Hello all!
I am having a look at failing tests and would fix soon.

@Aryaman1706
Copy link
Author

@SimonBrandner Can you please have a look and let me know if anything else is required.
Thank You.

SimonBrandner
SimonBrandner reviewed Nov 10, 2021
View reviewed changes
Copy link
Contributor

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

I am not the most knowledgeable about this part of the app, so better to leave the review to someone else. A review from a team member is required anyway

@Aryaman1706
Copy link
Author

@SimonBrandner Thank you for the response.
Can you let me know who all are the active maintainers so that I could tag them and ask for the review?

@SimonBrandner
Copy link
Contributor

Can you let me know who all are the active maintainers so that I could tag them and ask for the review?

A review from them has already been requested. You can see review requests in the top right corner

turt2live
turt2live requested changes Dec 28, 2021
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it seems fine - thanks! There's a few pieces to fix up here, and some merge conflicts to consider.

src/browser-index.ts
Comment on lines +26 to +28
enum IndexedDBStoreName {
crypto = "matrix-js-sdk:crypto"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a constant

src/browser-index.ts
crypto = "matrix-js-sdk:crypto"
}

type GlobalObject = NodeJS.Global & typeof globalThis & Record<"matrixcs", typeof matrixcs>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we already had a type for this? In general I don't think we should be touching global and should fix it.

src/browser-index.ts
Comment on lines +21 to +24
interface RequestOptions {
qs: string | Record<string | number | symbol, string>;
qsStringifyOptions: IStringifyOptions;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should be importing this type, not defining it.

@t3chguy
Copy link
Member

t3chguy commented May 10, 2022

@Aryaman1706 are you able to continue with this PR?

@MadLittleMods MadLittleMods added the Z-Community-PR Issue is solved by a community member's PR label Jun 2, 2022
@t3chguy
Copy link
Member

t3chguy commented Jul 6, 2023

This happened

@t3chguy t3chguy closed this Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonBrandner SimonBrandner SimonBrandner left review comments

@turt2live turt2live turt2live requested changes

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Aryaman1706 @SimonBrandner @t3chguy @turt2live @MadLittleMods