Element-R: wait for OlmMachine on startup #3487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if you called `CryptoApi.getUserDeviceInfo()` before the first `/sync` request happened, it would return an empty list, which made a bunch of the tests racy. Add a hack to get the OlmMachine to think about its device lists during startup.
t3chguy
requested changes
Jun 19, 2023
|
I think github flaked out. It was a very weird failure. |
t3chguy
requested changes
Jun 19, 2023
There was a problem hiding this comment.
This seems like it should have a test for the edge case you outlined in the description
Previously, if you called CryptoApi.getUserDeviceInfo() before the first /sync request happened, it would return an empty list, which made a bunch of the tests racy. Add a hack to get the OlmMachine to think about its device lists during startup.
|
your wish is my command |
richvdh
added a commit
that referenced
this pull request
Jun 20, 2023
A couple of tests were waiting for a request that wasn't happening, so timing out after 1.5 seconds. Let's avoid the extra slowth. (This was introduced by changes in #3487, but the changes in this PR do no harm anyway)
thanks for the test
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 22, 2023
A couple of tests were waiting for a request that wasn't happening, so timing out after 1.5 seconds. Let's avoid the extra slowth. (This was introduced by changes in #3487, but the changes in this PR do no harm anyway)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if you called
CryptoApi.getUserDeviceInfo()before the first/syncrequest happened, it would return an empty list, which made a bunch of the tests racy. Add a hack to get the OlmMachine to think about its device lists during startup.This change is marked as an internal change (Task), so will not be included in the changelog.