Don't attempt to adjust for clock skews when calculating group call membership expiry #4340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the spam, I meant to create this as draft in the first place. |
hughns
changed the title
AndrewFerr
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change proposes that we simplify the client side logic used to calculate when a MatrixRTC call membership has expired.
The current implementation attempts to adjust for differing clocks between the local client, remote clients, the local homeserver and federated/remote homeservers.
The proposed change simplifies the logic to assume that the participants are reasonably close with the local clock being: -infinity to +30mins skewed.
Checklist
public/exportedsymbols have accurate TSDoc documentation.