Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Cypress tests for read receipts - threaded and unthreaded #10872

Merged
merged 1 commit into from
May 12, 2023
Merged

Cypress tests for read receipts - threaded and unthreaded #10872

merged 1 commit into from
May 12, 2023

Conversation

andybalaam
Copy link
Contributor

@andybalaam andybalaam commented May 11, 2023 •
edited by github-actions bot
Loading

Fixes element-hq/element-web#25212

This change is marked as an internal change (Task), so will not be included in the changelog.

@andybalaam andybalaam added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label May 11, 2023
@andybalaam andybalaam force-pushed the andybalaam/cypress-tests-for-read-receipts branch from a9d6dfc to 12facaa Compare May 11, 2023 16:08
@andybalaam andybalaam marked this pull request as ready for review May 11, 2023 16:17
@andybalaam andybalaam requested a review from a team as a code owner May 11, 2023 16:17
@weeman1337 weeman1337 self-requested a review May 12, 2023 07:27
weeman1337
weeman1337 reviewed May 12, 2023
View reviewed changes
Copy link
Contributor

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Thanks.

What do you think about sending the remaining receipt in each test and verify that the unread count goes down to 0?

@andybalaam
Copy link
Contributor Author

Looks good +1 Thanks.

What do you think about sending the remaining receipt in each test and verify that the unread count goes down to 0?

I think this is covered by the other tests, and I'm not keen on tests that test more than one thing (although I admit that in system-level tests like this sometimes you have to do it).

So I'd prefer not, but could be persuaded.

@weeman1337
Copy link
Contributor

I think this is covered by the other tests, and I'm not keen on tests that test more than one thing (although I admit that in system-level tests like this sometimes you have to do it).

✔️

@andybalaam andybalaam added this pull request to the merge queue May 12, 2023
Merged via the queue into develop with commit 415fcde May 12, 2023
@andybalaam andybalaam deleted the andybalaam/cypress-tests-for-read-receipts branch May 12, 2023 09:43
richvdh pushed a commit that referenced this pull request May 12, 2023
@andybalaam @richvdh
Cypress tests for read receipts, threaded and unthreaded (#10872)
3415452
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@weeman1337 weeman1337 weeman1337 approved these changes

@germain-gg germain-gg Awaiting requested review from germain-gg germain-gg is a code owner automatically assigned from matrix-org/element-web-reviewers

@t3chguy t3chguy Awaiting requested review from t3chguy t3chguy is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test how we handle receiving an unthreaded read receipt
2 participants
@andybalaam @weeman1337