Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

enforced key backup setup #9729

Conversation

yasinishyn
Copy link

@yasinishyn yasinishyn commented Dec 8, 2022

This PR is an example of how element-hq/element-web#23810 issue could be fixed.
I am not adding tests for the purpose of seeing if this might gain tracking in the community

In terms of functionality it has two-fold:

  1. Redirect to encryption setup steps if the backup isn't set;
  2. hired "skip" buttons inside the backup flow windows.

This PR currently has none of the required changelog labels.

A reviewer can add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is, or add Type: [enhancement/defect/task] to the description and I'll add them for you.

Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks mostly fine. Clearing the review until we have tests and you have managed to get the feedback you're interested in having.

@dbkr
Copy link
Member

dbkr commented Dec 9, 2022

Making this a draft while it's still in progress.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants