Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hanging tests #727

Merged
merged 5 commits into from
Jun 20, 2023
Merged

Fix hanging tests #727

merged 5 commits into from
Jun 20, 2023

Conversation

alunturner
Copy link
Contributor

@alunturner alunturner commented Jun 20, 2023

Attempts to fix the hanging test problem by removing multi-threading from vitest

Closes #725

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.27 ⚠️

Comparison is base (227e6d9) 90.20% compared to head (9fa5396) 89.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #727      +/-   ##
==========================================
- Coverage   90.20%   89.94%   -0.27%     
==========================================
  Files         113       83      -30     
  Lines       16029    14587    -1442     
  Branches      565        0     -565     
==========================================
- Hits        14459    13120    -1339     
+ Misses       1550     1467      -83     
+ Partials       20        0      -20     
Flag Coverage Δ
uitests ?
uitests-ios ?
unittests 89.94% <ø> (+1.00%) ⬆️
unittests-ios ?
unittests-rust 89.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 30 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alunturner alunturner requested a review from a team June 20, 2023 13:39
@alunturner alunturner marked this pull request as ready for review June 20, 2023 13:39
Copy link
Contributor

@aringenbach aringenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alunturner alunturner merged commit e4fcd15 into main Jun 20, 2023
7 checks passed
@alunturner alunturner deleted the alunturner/fix-hanging-tests branch June 20, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test hanging in web
3 participants