Amend web conversion functions #735
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #735 +/- ##
==========================================
- Coverage 90.20% 89.94% -0.27%
==========================================
Files 113 83 -30
Lines 16029 14587 -1442
Branches 565 0 -565
==========================================
- Hits 14459 13120 -1339
+ Misses 1550 1467 -83
+ Partials 20 0 -20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Closing in favour of another branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on the blockquote rust fix. In draft until work is carried out to update the state management for the rich text editor in element web (required to be able to use this properly).
This supports work in element web to enable us to better parse the output from the plain text composer by reading from
.innerTextinstead of from.innerHTML. Required to address P2 for blockquote markdown not working in element web rte in plain mode.This work removes all the mentions tests as previously, mentions would persist when moving from plain to rich, but not from rich to plain modes. The upcoming PR on element web means that mentions will now become plain text when moving between modes in either direction.