-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sdk: Room Directory Search #3169
Conversation
also improved the integration test for the filtered case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great PR, thanks!
I've only reviewed the crates/matrix-sdk/src/room_directory_search.rs
file so far, as the rest of the code will need to be changed a bit. Feel free to ping if you've question, or if you need assistance.
testing/matrix-sdk-integration-testing/src/tests/room_directory_search.rs
Outdated
Show resolved
Hide resolved
and removed code from ffi that will be changed soon
into the check for the request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're making great progress!
Co-authored-by: Ivan Enderlin <[email protected]> Signed-off-by: Mauro <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3169 +/- ##
==========================================
+ Coverage 83.67% 83.72% +0.04%
==========================================
Files 236 237 +1
Lines 24396 24472 +76
==========================================
+ Hits 20413 20488 +75
- Misses 3983 3984 +1 ☔ View full report in Codecov by Sentry. |
…matrix-rust-sdk into mauroromito/directory_search
improved the conversion by using a try from and changed the nex_token to a search state to indicate the current state of the search
Co-authored-by: Ivan Enderlin <[email protected]> Signed-off-by: Mauro <[email protected]>
Signed-off-by: Ivan Enderlin <[email protected]>
Signed-off-by: Ivan Enderlin <[email protected]>
Implementing a service to allow for filtered public room search with pagination.